Fixed schema type not being deduced correctly in compute defaults #1334 #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@t-moe thanks! Can you add a test to make sure this bug doesn't regress? |
|
@epicfaace done |
epicfaace
reviewed
Jul 1, 2019
epicfaace
reviewed
Jul 1, 2019
epicfaace
requested changes
Jul 1, 2019
epicfaace
requested changes
Jul 2, 2019
|
Is there an Eta for this to be merged into master? |
|
Nothing pending, I just forgot to check on this. Thanks for the reminder @goralight ! |
|
@epicfaace No worries! Thank you for merging and thank you @t-moe for fixing the bug. Could we expect a release soon ? :D |
3 tasks
3 tasks
|
@epicfaace As mentioned, I'm not sure this is yet fully resolved in the latest commit. Would be great to hear your thoughts on this. It looks like the default values are rendered in the editor, but in some cases these default values are not actually part of the submitted formData. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
As described in bug report #1334, the "default" values of schemas are not correctly applied to anyOf/oneOf properties.
This PR fixes that.
anyOf/oneOf schema don't have 'type' properties sometimes, so we needed to use
getSchemaType(schema)instead ofschema.typeincomputeDefaultsChecklist